Make diff command a constant
Make diff command a constant

--- a/include/controller/Controller_Sidediff.class.php
+++ b/include/controller/Controller_Sidediff.class.php
@@ -145,7 +145,7 @@
 			array("blob", $this->params['hashparent']));
 		$blob  = explode("\n", $rawBlob);
 
-		$diffLines = explode("\n", $this->gitexe->Execute("diff",
+		$diffLines = explode("\n", $this->gitexe->Execute(GIT_DIFF,
 			array("-U0", $this->params['hashparent'],
 				$this->params['hash'])));
 

--- a/include/git/GitExe.class.php
+++ b/include/git/GitExe.class.php
@@ -25,6 +25,7 @@
 define('GIT_NAME_REV','name-rev');
 define('GIT_FOR_EACH_REF','for-each-ref');
 define('GIT_CONFIG','config');
+define('GIT_DIFF','diff');
 
 /**
  * Git Executable class

comments